New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add substream param to switch in VideoRoom #3197
Conversation
Apologies for this late response, I have been abroad for a few weeks. I think this is very incomplete at the moment. First of all, you're accessing a new property but not validating it, which is something we do automatically with |
Thanks for reply, I'll correct the request according to your comments. Right now we found out that By removing
from switch (along with setting substream param) we have no freezes at all. Plus, if only set substream but not remove _context_reset, I see bitrate spike right after switch. (Spike to default bitrate witch is max bitrate). I think it's understandable and that what context resetting causes - it resets to defaults. Maybe we don't need context resetting in switch at all? Simulcast context already been set, we working with existed stream, and just need new data in this stream, with ability to set desired substream. Why reset needed? What you think? |
The reset is needed because the video publisher is not the same. In fact, we reset and then copy the Are you sure the problem is not in |
Thanks, will try and let you know the results. Right now I deleted them both, and have no freezes, so may be it was vp8_simulcast_context_reset indeed. |
…ext reset on switch: Ability to specify substream while switching in VideoRoom. meetecho#3196
@lminiero I think you was right, janus_vp8_simulcast_context_reset was causing freezes, everything working good without it. Plus, I added validations and temporal layer param. Hope you'll take a look. |
Thanks for the patch! I'll have a look later this afternoon and merge if it works for me too 👍 |
Looks good, merging ✌️ |
I guess I'll have to add a similar approach for SVC as well, which at the moment isn't covered either. |
Thanks for your great work, man! |
Ability to specify substream while switching in VideoRoom.
#3196