Fixed memory leak in AudioBridge in case of late packets

meetecho · Jan 11, 2024 · a15e3fd · a15e3fd
1 parent e78232e
commit a15e3fd
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/plugins/janus_audiobridge.c b/src/plugins/janus_audiobridge.c
@@ -1130,6 +1130,7 @@ room-<unique room ID>: {
 #include <ogg/ogg.h>
 #endif
 #include <speex/speex_jitter.h>
+#define GE32(a,b) (((spx_int32_t)((a)-(b)))>=0)
 
 #include <arpa/inet.h>
 #include <net/if.h>
@@ -5913,7 +5914,11 @@ void janus_audiobridge_incoming_rtp(janus_plugin_session *handle, janus_plugin_r
 			jbp.len = 0;
 			jbp.timestamp = ntohl(rtp->timestamp);
 			jbp.span = (participant->codec == JANUS_AUDIOCODEC_OPUS ? 960 : 160);
-			jitter_buffer_put(participant->jitter, &jbp);
+			if(GE32(jbp.timestamp + jbp.span + jbp.span, jitter_buffer_get_pointer_timestamp(participant->jitter))) {
+				jitter_buffer_put(participant->jitter, &jbp);
+			} else {
+				janus_audiobridge_buffer_packet_destroy(pkt);
+			}
 			janus_mutex_unlock(&participant->qmutex);
 		}
 	}