Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): shipping & location #7151

Merged
merged 41 commits into from May 3, 2024
Merged

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Apr 25, 2024

What

  • new shipping and location domains

NOTEs

  • "Edit shipping options prices" modal is a todo (a followup PR)
  • deleted Locations are still returned when listing locations

Depends on


Screen.Recording.2024-04-30.at.16.11.30.mov

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: a23ab08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:22am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 3, 2024 9:22am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:22am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:22am

# Conflicts:
#	packages/admin-next/dashboard/src/v2-routes/shipping/location-create/components/create-location-form/create-location-form.tsx
@olivermrbl
Copy link
Contributor

The left border on the "View details" button seems off. Should it even be there?

CleanShot 2024-05-01 at 14 51 36

@olivermrbl
Copy link
Contributor

olivermrbl commented May 1, 2024

When I create a new location, I get a 404. Think the URL is wrong:
CleanShot 2024-05-01 at 15 08 23

@olivermrbl
Copy link
Contributor

It seems enabling pick up doesn't work as expected. See video below. I presume we are switching on the type somewhere incorrectly:

CleanShot.2024-05-01.at.15.14.08.mp4

@fPolic
Copy link
Contributor Author

fPolic commented May 2, 2024

@olivermrbl should be fixed now.

@sradevski
Copy link
Member

I didn't go through the code, but for what is worth it it works as expected when I tested it.

@olivermrbl olivermrbl merged commit e423085 into develop May 3, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/shipping-refresh branch May 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants