Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation for toast component changes #7141

Merged
merged 8 commits into from May 1, 2024

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Apr 24, 2024

Note: This PR requires updating the UI package before merging, hence why it's in draft, but the content can still be reviewed. Once the changes in the toast component are released, I'll open the PR for merging.

  • Update the Toast UI documentation
  • Remove the useToast documentation + add a rewrite to the upgrade guide
  • Update the generated Toast and Toaster props
  • Update the examples of the toast components
  • Added an upgrade guide for UI v3

FYI: The build will fail until the Medusa UI package is updated.

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: d377354

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview May 1, 2024 9:45am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:45am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:45am
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:45am

@shahednasser
Copy link
Member Author

@olivermrbl can we get this one in?

@shahednasser shahednasser merged commit b6083ce into develop May 1, 2024
30 checks passed
@shahednasser shahednasser deleted the docs/ui-toast branch May 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants