New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): metadata component #7117
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
# Conflicts: # packages/medusa/src/api-v2/admin/customers/query-config.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe confirm with @ludvig18, but I think the intended behaviour is the same as what we have in the current admin. So when a user hovers a row, it should show a menu button, where from the user can delete the row, insert an empty row above and below.
Re inferring the type based on the input: I think its a cool idea, but also a bit dangerous as someone might write "true" and want the string and not boolean value. If we added the menu as we have in the existing component, we could potentially have a submenu called "Type", which has options based on what the value could be cast as. So if the user writes "true" the submenu would have the options "String" and "Boolean". In that case we would properly also need some kind of visual indication what the field is currently cast to.
Think we can merge this now since the API of the component won't change so we can start adding this to UIs. I discussed with Ludvig and we will add a context menu with (Delete, Add row below/above) instead of the current delete action but this isn't blocking. |
What
Note
Screen.Recording.2024-04-22.at.12.36.25.mov