Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to page headers #6899

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

danielrodcaball
Copy link

What

  • Add translation capabilities to TableViewHeader.

  • Add translation to orders and draft page headers.

  • Add translation to products and collections page headers.

  • Add translation to clients and groups page headers.

  • Add translation to price lists page header.

Why

Labels and texts are fixed in English.

How

  • Using react-i18next for translations.

  • For TableViewHeader added a View type with key and label to the views props. The former is used to identify the active view, the later for the string to display.

@danielrodcaball danielrodcaball requested a review from a team as a code owner April 1, 2024 15:32
Copy link

vercel bot commented Apr 1, 2024

@danielrodcaball is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Apr 1, 2024

⚠️ No Changeset found

Latest commit: 134ec7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant