Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discountable-form translations (es and en). #6854

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

danielrodcaball
Copy link

What

English and Spanish translations to packages/admin-ui/ui/src/components/forms/product/discountable-form/index.tsx

Why

Labels and texts are fixed in English.

How

Using react-i18next for translations.

@danielrodcaball danielrodcaball requested a review from a team as a code owner March 28, 2024 00:40
Copy link

changeset-bot bot commented Mar 28, 2024

⚠️ No Changeset found

Latest commit: 199d0f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 28, 2024

@danielrodcaball is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

danielrodcaball

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant