Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general-form translations (es and en). #6853

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add general-form translations (es and en). #6853

wants to merge 2 commits into from

Conversation

danielrodcaball
Copy link

@danielrodcaball danielrodcaball commented Mar 27, 2024 •
edited

What

English and Spanish translations to packages/admin-ui/ui/src/components/forms/product/general-form/index.tsx

Why

Labels and texts are fixed in English.

How

Using react-i18next for translations.

PD: first pr :)

@danielrodcaball danielrodcaball requested a review from a team as a code owner March 27, 2024 23:55
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited

⚠️ No Changeset found

Latest commit: 1402bd1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024

@danielrodcaball is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

danielrodcaball
danielrodcaball commented Mar 27, 2024
View reviewed changes
packages/admin-ui/ui/public/locales/en/translation.json
Comment on lines +952 to +953
"general-form-description-hint-0-gift-card": "Give your gift card a short and clear description.",
"general-form-description-hint-0-product": "Give your product a short and clear description.",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using two entries for the multi-line hint

danielrodcaball
danielrodcaball commented Mar 27, 2024
View reviewed changes
packages/admin-ui/ui/public/locales/en/translation.json
Comment on lines +936 to +937
"general-form-title-hint-0-gift-card": "Give your gift card a short and clear title.",
"general-form-title-hint-0-product": "Give your product a short and clear title.",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using two entries for the multi-line hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielrodcaball