fix(agent): return non-200 status when > 0 failures in bulk op #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
codyebberson
requested changes
May 6, 2024
| continue; | ||
| } | ||
| const [outcome, params] = result.value; | ||
| if (!isOk(outcome)) { | ||
| failureCount += 1; |
There was a problem hiding this comment.
I recommend we save the outcome here and use it to determine status.
++?
There was a problem hiding this comment.
It's possible that you get multiple different types of outcomes, should we just save the first one?
| @@ -233,7 +233,7 @@ describe('Agent/$bulk-status', () => { | |||
| .get('/fhir/R4/Agent/$bulk-status') | |||
| .query({ name: 'Test Agent 2' }) | |||
| .set('Authorization', 'Bearer ' + accessToken); | |||
| expect(res.status).toBe(200); | |||
| expect(res.status).toBe(500); | |||
There was a problem hiding this comment.
We should never intentionally return a 500 - that should be reserved for unexpected errors.
| @@ -132,7 +138,7 @@ export async function handleBulkAgentOperation( | |||
| } | |||
|
|
|||
| return [ | |||
| allOk, | |||
| failureCount === 0 ? allOk : serverError(new Error(`${failureCount} sub-operations failed`)), | |||
There was a problem hiding this comment.
Use the saved outcome here rather than serverError
|
See explanation #4513 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.