Return VideoBuffer to VideoBufferPool when shared pointer is destroyed #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current code was just a factory, it didn't return the object to the pool when it was released |
harryz2000
reviewed
May 14, 2024
harryz2000
reviewed
May 14, 2024
harryz2000
reviewed
May 14, 2024
include/VideoBufferPool.h
Outdated
| pool->enqueue(p); | ||
| } else { | ||
| //Delete it | ||
| delete (buffer); |
There was a problem hiding this comment.
I think this should be changed to delete p. For example, if the shared_ptr.reset(new VideoBuffer) is called, the deleter should not always try to delete the pointer when the shared_ptr was constructed.
bcostdolby
reviewed
May 15, 2024
| //Try to get a reference to the pool, as it may have been already deleted | ||
| auto pool = weak.lock(); | ||
| //Ensure we are not overallocating | ||
| if (maxallocate && pool && pool->size_approx() < maxallocate) |
There was a problem hiding this comment.
If pool can go out of scope then can this->maxallocated also be out of scope?
There was a problem hiding this comment.
right, I thought about this, but not sure why I concluded that the = in the capture was going to make a copy of it. Capturing it explicitly now.
murillo128
commented
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.