Use VideoFrames as input for VideoDecoders #281
+262
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildsunrise
approved these changes
May 14, 2024
|
I see you also adapted medooze/video-codecs-node#9 to be compatible with the new changes, thanks! |
mildsunrise
reviewed
May 14, 2024
| { | ||
| //Create new codec from pacekt | ||
| videoDecoder.reset(VideoCodecFactory::CreateDecoder((VideoCodec::Type)packet->GetCodec())); | ||
| videoDecoder.reset(VideoCodecFactory::CreateDecoder((VideoCodec::Type)videoFrame->GetCodec())); |
There was a problem hiding this comment.
cast no longer needed, better remove it
Suggested change
| videoDecoder.reset(VideoCodecFactory::CreateDecoder((VideoCodec::Type)videoFrame->GetCodec())); | |
| videoDecoder.reset(VideoCodecFactory::CreateDecoder(videoFrame->GetCodec())); |
mildsunrise
reviewed
May 14, 2024
| packets.Add(packet->Clone()); | ||
| } | ||
| //Ensure it is video | ||
| if (frame.GetType()!=MediaFrame::Video) |
There was a problem hiding this comment.
hmm, I see you removed the Warning() here, any particular reason?
|
we have a problem with ffmpeg expecting annexb h26X streams while we are feeding non-annexb with the default packetizers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yakes over the work done in #271