h.26x: refactor descriptor Dump / Decode logic #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nested objects are treated very differently by Dump(), and the output syntax differs a lot between objects, so introduce a base Descriptor class and macros to avoid repeating stuff like the field name. Dump() now takes an optional prefix, so that nested objects are dumped with the same syntax but indented as needed.
mildsunrise
force-pushed
the
dev/alba/descriptor-base
branch
from
7be3408
to
2a8778c
Compare
typeid(x) on a polymorphic type relies on RTTI to work, and we have that disabled for the Node.js addons. switch to static polymorphism to avoid that. (also known as the "Curiously Repeating Template Pattern")
mildsunrise
force-pushed
the
dev/alba/descriptor-base
branch
from
07b20e9
to
95695b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a lot of repetitive work when writing the Dump() function, and there's also the
CHECKmacro that we define in several files... move that to a singledescriptor.hheader, and introduce some more macros + a base class to remove most of the repetitive work.