Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate community bundle via GitHub Actions #193

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Mar 1, 2024

Why we need this PR:

Currently, the GitHub Action workflow is only able to create a RH/OKD bundle, while SNR is also supported in K8S community.
Moreover, the need of inputs like previous version does not allow to keep using the automatic CI for the release.

Changes made

Create a manual workflow to provide the necessary inputs to the shared
GitHub Action to:

  • build and push versioned images to quay registry
  • create the OKD release branch, ready for the PR
  • create the K8S release branch, ready for the PR

Which issue(s) this PR fixes

It contributes to solving
ECOPROJECT-1579

Test plan

Tested locally via nektos/act.

Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@clobrano
Copy link
Contributor Author

clobrano commented Mar 1, 2024

/hold
I realized only now that we could just put the same workflow under the .github special repository and make it available for all operatores at once. I need to try

@clobrano
Copy link
Contributor Author

clobrano commented Mar 1, 2024

Unfortunately it is not possible. Each repository has to at least call the reusable workflow from its own action

/unhold

@clobrano
Copy link
Contributor Author

clobrano commented Mar 4, 2024

/hold
it seems that conditional workflow isn't working too well, need to investigate

@clobrano clobrano force-pushed the automate-community-bundle-parametric-0 branch from 4ce4464 to 710114a Compare March 4, 2024 15:53
@clobrano
Copy link
Contributor Author

clobrano commented Mar 4, 2024

/unhold

again. Verified that the conditionals work fine now

@clobrano
Copy link
Contributor Author

/hold
Waiting for medik8s/node-healthcheck-operator#300

@clobrano clobrano changed the title Automate K8s community bundle via GitHub Actions [WIP] Automate K8s community bundle via GitHub Actions Mar 19, 2024
@clobrano clobrano force-pushed the automate-community-bundle-parametric-0 branch 2 times, most recently from e82ab0e to a0ec912 Compare May 2, 2024 12:29
@clobrano clobrano changed the title [WIP] Automate K8s community bundle via GitHub Actions Automate K8s community bundle via GitHub Actions May 2, 2024
Create a manual workflow to provide the necessary inputs to the shared
GitHub Action to:
- build and push versioned images to quay registry
- create the OKD release branch, ready for the PR
- create the K8S release branch, ready for the PR

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@clobrano clobrano force-pushed the automate-community-bundle-parametric-0 branch from a0ec912 to d5d3d9b Compare May 2, 2024 15:56
@clobrano clobrano changed the title Automate K8s community bundle via GitHub Actions Automate community bundle via GitHub Actions May 3, 2024
@clobrano
Copy link
Contributor Author

This change is now ready
I forgot to /unhold

The job "Create release with manifests" is not triggered by tag anymore
so we need to:

- remove the condition on github.ref_type to let the job run manually.
- add explicit tag field "Create release with manifests, for tags" from
  inputs.version.
- replace github.ref_name with input.version when the version is needed.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@clobrano
Copy link
Contributor Author

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant