fix(#8886): block users from editing important fields in their settings #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethbowen
commented
May 10, 2024
| ) { | ||
| 'use strict'; | ||
| 'ngInject'; | ||
|
|
||
| const getHtml = string => { | ||
| return $sanitize(PrivacyPolicies.decodeUnicode(string)); |
There was a problem hiding this comment.
This is a refactor that I found while working out the privacy policy fields in user settings - by inlining this one function we can drop the entire service.
garethbowen
commented
May 10, 2024
| @@ -13,11 +13,42 @@ function(newDoc, oldDoc, userCtx) { | |||
| throw({ forbidden: msg }); | |||
| }; | |||
|
|
|||
| var hasRole = function(roles, role) { | |||
There was a problem hiding this comment.
Copied from the server validate_doc_update function. We don't yet have a sensible way to include functions like this.
garethbowen
commented
May 10, 2024
| return true; | ||
| } | ||
|
|
||
| if (secObj.admins && secObj.admins.roles) { | ||
| for (var i = 0; i < userCtx.roles; i++) { | ||
| if (hasRole(secObj.admins, userCtx.roles[i])) { | ||
| for (var i = 0; i < userCtx.roles.length; i++) { |
There was a problem hiding this comment.
There was a bug here - without the .length this loop was never executing so national_admins were blocked. Found when adding unit tests for this PR.
garethbowen
commented
May 10, 2024
| // A valid user-settings doc. Does not require type property because that is | ||
| // already matched before passing to the validation function. | ||
| userSettings = { | ||
| const wrapValidateDocUpdate = (file) => eval(`log = console.log; (${fs.readFileSync(__dirname + file)})`); |
There was a problem hiding this comment.
I refactored this significantly to make it easier to add to. Sorry for the noise!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8886
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.