feat(#8551): removes python from cht-deploy and some bug fixes #9074
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Awesome work here! Nice to see a migration to node for user/developer facing scripts. As well, I saw you closed some other issues with this PR like #8604, #8605 and #8608 - sweet!
I found two errors - one I'm requesting a change for and the other is in master, but persists in this branch. Let's make the change per my request and then wait til the other issue fixed and we'll dive back into this PR!
There was a problem hiding this comment.
Great initiative! I'm happy to see significant progress in replacing the old script.
I would love to see a test, even if it's just trying to import the module or testing the easiest to test function as it can catch some syntax errors and make it easier to add more tests later. Since the old script didn't have any tests I don't consider this a blocker, even in the current state I consider it an significant improvement.
I think some jsdoc style comments on most functions would be great
There was a problem hiding this comment.
Looking better - thanks for iterating!
Confirmed that #9076 is fixed with the latest changes. As well, sad path and happy paths are well covered!
Requesting some security and changes to new save all logs script.
| @@ -0,0 +1,46 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
yay! this worked exactly as promised - thanks for adding!
Co-authored-by: Daniel <nydr@users.noreply.github.com>
jonathanvq
added this to Awaiting Triage
in Site Reliability Support Dashboard
via automation
jonathanvq
moved this from Awaiting Triage
to This Week's Priorities
in Site Reliability Support Dashboard
| const releaseExists = child_process.execSync(`helm list -n ${namespace}`).toString(); //NoSONAR | ||
| if (releaseExists.includes(project_name)) { //NoSONAR | ||
| console.log("Release exists. Performing upgrade."); | ||
| child_process.execSync(`helm upgrade --install ${project_name} ${CHT_CHART_NAME} --version ${chart_version} --namespace ${namespace} --values ${valuesFile} --set cht_image_tag=${image_tag}`, { stdio: 'inherit' }); //NoSONAR |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Description
Handles the following tickets:
#8551 Remove python - establishing feature parity. No major refactoring.
#8604 Catch Missing Values
#8605 Show URL when done execution
#8608 Add a get-all-logs troubleshooting command
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.