Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using captionsButton instead of getElementById. Fixed fullscreen. #2927

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kachaj7
Copy link

@kachaj7 kachaj7 commented Apr 6, 2023

I'm using player as webcomponent and using document to find elements is impossible.

Łukasz Kaczmarek added 3 commits April 5, 2023 15:37
@kachaj7
Copy link
Author

kachaj7 commented Apr 13, 2023

Reverted 66a031d this destroys rotating video. This fix makes the problem as described in the comment.

@kachaj7 kachaj7 changed the title Using captionsButton instead of getElementById. Using captionsButton instead of getElementById. Fixed fullscreen. Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant