Fixes issue #2879 #2880
Open
Fixes issue #2879 #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to the SVG template. a) viewBox size The default size is 20 x 20. For "icon-captions" and "icon-chapters" the viewBox is 18 x 18 (pixels) to display them as larger buttons. b) SVG layout Icons are arranged in the traditional formation. Top row: play | pause | unmute | mute | fullscreen | unfullscreen | [captions] | captions | replay | chapters Bottom row: overlay-play | [overlay-play] | loading-spinner CSS sources To match the SVG viewBox, the button size is increased to 1.25 rem by 1.25 (20x20 pixels).
I forgot to update the loading-spinner viewBox.
|
Can't believe this is still busted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the SVG template.
a) viewBox size
The default size is 20 x 20. For "icon-captions" and "icon-chapters" the viewBox is 18 x 18 (pixels) to display them as larger buttons.
b) SVG layout
Icons are arranged in the traditional formation.
Top row: play | pause | unmute | mute | fullscreen | unfullscreen | [captions] | captions | replay | chapters
Bottom row: overlay-play | [overlay-play] | loading-spinner
CSS sources
To match the SVG viewBox, the button size is increased to 1.25 rem by 1.25 (20x20 pixels).