Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep std vertical resolution and extend horizontal if input is not 16/9 #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morbificagent
Copy link

No description provided.

@mgogoulos
Copy link
Contributor

How does this change affect videos of 16/9?

@morbificagent
Copy link
Author

Hi mgogoulos,

16/9 content isnt affected/changed in any way.

This code-change only affects content which isnt 16/9 and want to "expand" over this 16/9-limits.
The original code was scaling the video so it fits in a 16/9 "Box"... A 23/9 video would become something like 16/6 or whatever, because it MUST fit in a 16/9 box. So the vertical resolution is changed to strange values and is displayed loke described. With this change it can extend horizontal, keeping the vertical resolution in standard 480, 720, 1080,... formats.

@mgogoulos
Copy link
Contributor

Hey didn't get the chance to test this out. Wondering if you have a video available that I can try this out (eg if you have uploaded something on demo.mediacms.io). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants