Only one getVideoOutParams #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23doors
reviewed
May 13, 2024
| width: Double(width ?? (params.rotate == 0 || params.rotate == 180 | ||
| ? params.dh | ||
| : params.dw)), | ||
| height: Double(height ?? (params.rotate == 0 || params.rotate == 180 |
There was a problem hiding this comment.
@moffatman seems like a mistake?
Previously: width = params.rotate == 0 || params.rotate == 180 ? dw : dh
Now it's: width = params.rotate == 0 || params.rotate == 180 ? dh : dw (swapped)
Same for height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little optimization, because these calls to
MPVHelpers.getVideoOutParamsare not allowed at this time (in render callback), it causes some jank (at end of looping video is most obvious). Personally I work around it by eagerly using setSize. However, we can also take a simple optimization to avoid calling it twice for both width and height when it returns both.