Fix subtitle view #691
Fix subtitle view #691
Conversation
|
I'm using your solution in production since a few weeks, it works pretty well ❤️ |
Glad it worked ❤️ |
| @@ -83,6 +83,10 @@ class SubtitleViewState extends State<SubtitleView> { | |||
| /// {@macro subtitle_view} | |||
| @override | |||
| Widget build(BuildContext context) { | |||
| subtitle = widget.controller.player.state.subtitle; | |||
There was a problem hiding this comment.
what's the purpose of these guys?
There was a problem hiding this comment.
these allow new values to of the player to be used on build
There was a problem hiding this comment.
a better way to do it is just ignoring the local variable and just use widget.controller.player.state.subtitle for example
what do you think?
There was a problem hiding this comment.
Yeah don't cache it locally if you don't have to.
There was a problem hiding this comment.
removed the two variables that doesnt need caching and only kept the padding since it needs to have the cache
i added the fit timer, for the sake of viewing that fit can be changed too using the update method, since people didnt know how |
No description provided.