Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex fix that failed to load cookie from store. #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StotoV
Copy link

@StotoV StotoV commented Feb 19, 2021

The regex did not take into account that spaces around the cookie entries are possible.
This fix remedies that by expanding the regex rule in the javascript.
Further documentation: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie

The regex did not take into account that spaces around the cookie entries are possible.
This fix remedies that by expanding the regex rule in the javascript.
Further documentation: https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie
@ddiestra
Copy link

I was working with this library today and I found your fix, but that fix is actually incorrect as well, the space is accounted the problem is the use of `` strings on js, instead of
(?:^|;\s*)${CSRFP.CSRFP_TOKEN}=([^;]+)(;|$)

should be
(?:^|;\\s*)${CSRFP.CSRFP_TOKEN}=([^;]+)(;|$)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants