Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iframe spinner during slow loads #429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Apr 10, 2024

If loading takes over 500ms, show a spinner before rendering the iframe.

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:25pm
puck-docs ✅ Ready (Inspect) Visit Preview Apr 24, 2024 6:25pm

@@ -55,5 +55,24 @@

.PuckCanvas--ready .PuckCanvas-root {
opacity: 1;
transition: opacity 150ms ease-out;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should remove this transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant