Fix issues with starting sponge #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got the following error block after installing 1.1.0 on every new tab.
```
contains: Key not specified
test: Unexpected argument type at index 1
= true -a true = true
^
~/.config/fish/functions/sponge_filter_failed.fish (line 4):
if test $previously_in_history = true -a $sponge_allow_previously_successful = true
^
in function 'sponge_filter_failed' with arguments '0 ""'
called on line 14 of file ~/.config/fish/functions/_sponge_on_postexec.fish
in function '_sponge_on_postexec'
called on line 1 of file ~/.config/fish/config.fish
in event handler: handler for generic event “fish_postexec”
called on line 378 of file ~/.config/fish/config.fish
```
This fixes both issues. Everything else *appears* to work. This may
address meaningful-ooo#4.
|
I'm not convinced that this is related to #4 anymore, but I have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error block after installing 1.1.0 on every new tab.
This fixes both issues. Everything else appears to work. This may
address #4.