feat: Update Shopping List Timestamp on List Item Update #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR listens for list item events (create, update, delete) and updates the parent list so the
update_atproperty is changed.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3449
Special notes for your reviewer:
The
SessionBufferclass is used so the shopping list is only updated once per commit (otherwise a bulk update of 10 items would update the shopping list 10 times). The use of theContextVaris to prevent race conditions in the FastAPI ASGI context (similar issue to having a global variable shared by multiple threads).Testing
Pytest