Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Suggestion To Use Bulk URL Import #2852

Conversation

michael-genson
Copy link
Collaborator

@michael-genson michael-genson commented Dec 15, 2023

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

One thing that's bugged me is that some of the "create recipe" options are hidden. You basically have to click on "Import Recipe" to get to the create page, then switch to the "hidden" one.

This PR makes it a bit easier for users to stumble upon the bulk URL importer. There are still two other "hidden" menu options (scraper debugger and .zip importer) but the former makes sense (most people won't use it, and those that will use it will find it) and the latter should be addressed along with #2802.

I originally considered putting the hidden options in the main sidebar, but I found it too cluttered, I like how simple it is currently.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2928

Special notes for your reviewer:

(fill-in or delete this section)

If there's a better way to handle the hyperlink let me know. I used href because using router-link won't update the menu. I considered rigging up an emit so the parent component can handle it, but it seemed like more of a refactor than it was worth.

Testing

(fill-in or delete this section)

Manually

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuchenpirat Kuchenpirat enabled auto-merge (squash) January 9, 2024 14:36
@Kuchenpirat Kuchenpirat merged commit 1e4fde8 into mealie-recipes:mealie-next Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - "Looking for Migrations" Link on create recipe page not working
3 participants