Switch to workflow actions and upload to GHCR #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
reviewed
May 13, 2023
| file: docker/api.Dockerfile | ||
| context: . | ||
| push: true | ||
| tags: api-${{ steps.meta.outputs.tags }} |
There was a problem hiding this comment.
Shouldn't this be ${{ inputs.tag }} like before?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
hay-kot
force-pushed
the
feature/push_to_ghcr
branch
from
802f8d7
to
2232649
Compare
hay-kot
force-pushed
the
feature/push_to_ghcr
branch
from
52e80ad
to
45907b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Dockerhub have been restricting the number of times that an IP Address can download an image without paying for their monthly subscription. This PR uploads the image to Github Container Registry as well as DockerHub so we can truly distribute free software for free.
As part of this, I've also moved from the existing Bash commands to the "official" github action for building and pushing docker containers. This may mean it needs refinement to ensure that the tags work properly however it should also reduce the overhead of adding new architectures etc.
Which issue(s) this PR fixes:
(REQUIRED)
N/A - No github issue raised
Release Notes
(REQUIRED)