Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - group/data/recipes/ does not handle imports (at all) #2802

Open
6 tasks done
duckhead opened this issue Dec 8, 2023 · 8 comments
Open
6 tasks done

[BUG] - group/data/recipes/ does not handle imports (at all) #2802

duckhead opened this issue Dec 8, 2023 · 8 comments
Labels
bug: confirmed bug Something isn't working

Comments

@duckhead
Copy link

duckhead commented Dec 8, 2023

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

This page should allow the export and import of recipes. Right now, the export appears to work, but the facility to import is not. It looks like the flow is to go like this:

  1. Select an export to import.
  2. Display the items in that export.
  3. Select which items you want to import.
  4. Press the Import button.

The issue is that there is no way to import the export file. So, the entire process breaks.

Steps to Reproduce

Go to group/data/recipes

Done, there is no way to provide an export file to import.

Please provide relevant logs

No logs are produced.

Mealie Version

v1.0.0-RC1.1

Deployment

Other

Additional Deployment Details

Kubernetes helm chart on TrueNAS SCALE.

@duckhead duckhead added bug Something isn't working triage labels Dec 8, 2023
@Kuchenpirat
Copy link
Collaborator

can confirm
Guess this is currently a placeholder button, as it seems that there is no functionality linked to it.

<BaseButton color="info">
<template #icon>
{{ $globals.icons.database }}
</template>
{{ $t('general.import') }}
</BaseButton>

@duckhead
Copy link
Author

duckhead commented Dec 8, 2023

I think the button you are referring to is the one in step 4 (the last one), which would actually import the data from the export file. Having it not do anything is certainly an issue, of course.

What I'm talking about is the front end of the process. Where you pick an exported file, Mealie uploads, parses, and displays the objects in it. Those pieces don't exist on the page yet.

@Kuchenpirat
Copy link
Collaborator

ok, sorry, the workflow above is a bit confusing.
my idea for a workflow was

  1. export selected recipes (working)
  2. download export (working)
  3. click import button
  4. import dialog opens
  5. upload file
  6. (optional) select which recipes to import
  7. confirm import

@michael-genson
Copy link
Collaborator

Which exports are you referring to? Recipe exports?

You can import Recipe ZIP files on the "create recipe" page:
image

https://demo.mealie.io/recipe/create/zip

Though I agree it should also be available on the data management page

@duckhead
Copy link
Author

OK, that does work for a single recipe on the demo instance. The data management page does multiple recipes in one zip though, and I suspect that may very well not work. Also, the demo instance now has my chili recipe on it, if you cook.

@michael-genson
Copy link
Collaborator

Yeah good point, so we need to add some basic multi-recipe parsing there

the demo instance now has my chili recipe on it

Don't mind me just nabbing that...

@duckhead
Copy link
Author

That's why I used it. I have no issue sharing my recipes.

@duckhead
Copy link
Author

But seriously, I don't care how it's implemented. I just want it to work, and for the directions to be clear enough that someone can export their recipes and someone else can import them. If data management page just does exports that's fine. Change it to not attempt to import, and put a note in there that says "Hey, to import these, do the following"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants