Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky tests #342

Merged
merged 3 commits into from
May 5, 2023
Merged

Remove flaky tests #342

merged 3 commits into from
May 5, 2023

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented May 2, 2023

Purpose

This test has caused problems in the past and now it's caused one conda-forge build to fail. I think it's probably best to just remove this time, don't think it's adding much value anyways.

Expected time until merged

Not urgent.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner May 2, 2023 01:06
@ewu63 ewu63 requested review from lamkina and sseraj May 2, 2023 01:06
@ewu63
Copy link
Collaborator Author

ewu63 commented May 2, 2023

Given that we've hit #340 quite a few times now, do we want to just skip the multi-objective NSGA2 tests here until that's sorted?

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #342 (ca90856) into main (298c48c) will decrease coverage by 11.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #342       +/-   ##
===========================================
- Coverage   83.97%   72.29%   -11.68%     
===========================================
  Files          22       22               
  Lines        3363     3364        +1     
===========================================
- Hits         2824     2432      -392     
- Misses        539      932      +393     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano
marcomangano previously approved these changes May 3, 2023
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

marcomangano
marcomangano previously approved these changes May 3, 2023
lamkina
lamkina previously approved these changes May 4, 2023
@ewu63 ewu63 dismissed stale reviews from lamkina and marcomangano via ca90856 May 4, 2023 22:18
@ewu63
Copy link
Collaborator Author

ewu63 commented May 4, 2023

The RTD failure is tracked at readthedocs/readthedocs#10290, we should be able to safely ignore it.

@sseraj sseraj changed the title Remove flaky timing-based test Remove flaky tests May 4, 2023
@marcomangano
Copy link
Contributor

I will have @eirikurj merging this because I do not have the authority to override the required docs test

@ewu63
Copy link
Collaborator Author

ewu63 commented May 5, 2023

I'm gonna exercise my power before they're gone :)

@ewu63 ewu63 merged commit 6acea68 into mdolab:main May 5, 2023
10 of 12 checks passed
@ewu63 ewu63 deleted the fix-timing-test branch May 5, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants