Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spanwise Local DV offset #243

Merged
merged 3 commits into from Apr 29, 2024
Merged

Fix spanwise Local DV offset #243

merged 3 commits into from Apr 29, 2024

Conversation

joanibal
Copy link
Collaborator

Purpose

The title says it all.
It's a small fix for cases where you have spanwiseLocalDV and other variables.
Right now, self.nDVSW_count defaults to 0 causing it to overwrite other columns of the Jacobian.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@joanibal joanibal requested a review from a team as a code owner April 17, 2024 00:37
@joanibal joanibal requested review from hajdik and anilyil April 17, 2024 00:37
@joanibal
Copy link
Collaborator Author

I don't think the failing docs are my fault

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/cmd/build.py", line 332, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/application.py", line 268, in __init__
    self._init_builder()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/application.py", line 338, in _init_builder
    self.builder.init()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/builders/html/__init__.py", line 228, in init
    self.init_templates()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/builders/html/__init__.py", line 278, in init_templates
    self.theme = theme_factory.create(theme_name)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/theming.py", line 228, in create
    themes, theme_dirs, tmp_dirs = _load_theme_with_ancestors(self._themes, name)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/theming.py", line 266, in _load_theme_with_ancestors
    raise ThemeError(msg)
sphinx.errors.ThemeError: The 'sphinx_mdolab_theme' theme inherits from 'sphinx_rtd_theme', which is not a loaded theme. Loaded themes are: agogo, alabaster, basic, bizstyle, classic, default, epub, haiku, nature, nonav, pyramid, scrolls, sphinx_mdolab_theme, sphinxdoc, traditional

Theme error:
The 'sphinx_mdolab_theme' theme inherits from 'sphinx_rtd_theme', which is not a loaded theme. Loaded themes are: agogo, alabaster, basic, bizstyle, classic, default, epub, haiku, nature, nonav, pyramid, scrolls, sphinx_mdolab_theme, sphinxdoc, traditional

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.46%. Comparing base (ad9338a) to head (7d1a475).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files          47       47           
  Lines       12265    12266    +1     
=======================================
+ Hits         8029     8030    +1     
  Misses       4236     4236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eirikurj
Copy link
Contributor

@joanibal docs build failed due to recent sphinx updates, which are now patched. For some reason, the intel build timed out, but restarting seems to have fixed it.

Copy link
Contributor

@hajdik hajdik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hajdik hajdik merged commit 44a25b3 into mdolab:main Apr 29, 2024
11 checks passed
@joanibal joanibal deleted the fix_sw_dvs branch April 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants