Add composite DVs (#119)

* initial merge from old branch

* added some error checking

* renamed variables

* scale the scaling

* refactored slightly

* revert complex changes since they are incompatible with DVGeoMulti

* added docstrings and warning

* renamed compName to useCompositeNames

* flake8 fix

* renamed function to addCompositeDV, added docstring

* version bump

pygeo/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "1.9.0"
+__version__ = "1.10.0"
 
 from .pyNetwork import pyNetwork
 from .pyGeo import pyGeo

pygeo/constraints/areaConstraint.py

@@ -86,11 +86,11 @@ def getVarNames(self):
         variables, but some constraints may extend this to include other variables.
         """
         if self.DVGeo1 is not None:
-            varnamelist = self.DVGeo1.getVarNames()
+            varnamelist = self.DVGeo1.getVarNames(pyOptSparse=True)
             if self.DVGeo2 is not None:
-                varnamelist.extend(self.DVGeo2.getVarNames())
+                varnamelist.extend(self.DVGeo2.getVarNames(pyOptSparse=True))
         else:
-            varnamelist = self.DVGeo2.getVarNames()
+            varnamelist = self.DVGeo2.getVarNames(pyOptSparse=True)
 
         return varnamelist
 

pygeo/constraints/baseConstraint.py

@@ -2,6 +2,7 @@
 #         Imports
 # ======================================================================
 from abc import ABC, abstractmethod
+from collections import OrderedDict
 import numpy as np
 from baseclasses.utils import Error
 
@@ -56,7 +57,7 @@ def getVarNames(self):
         return the var names relevant to this constraint. By default, this is the DVGeo
         variables, but some constraints may extend this to include other variables.
         """
-        return self.DVGeo.getVarNames()
+        return self.DVGeo.getVarNames(pyOptSparse=True)
 
     def addConstraintsPyOpt(self, optProb, exclude_wrt=None):
         """
@@ -256,6 +257,32 @@ def _finalize(self):
         # with-respect-to are just the keys of the jacobian
         self.wrt = list(self.jac.keys())
 
+        # now map the jac to composite domain:
+        # we assume jac is always only wrt "local" DVs
+        if self.DVGeo.useComposite:
+            nDV = self.DVGeo.getNDV()
+            # for the jac, we need to "pad" the rest of the matrix with zero, then perform mat-mat product
+            newJac = np.zeros((self.ncon, nDV))
+            for i in range(self.ncon):
+                temp_dict = {}
+                # all_DVs just contains all the DVs so we can loop over them easily
+                all_DVs = OrderedDict({})
+                all_DVs.update(self.DVGeo.DV_listGlobal)
+                all_DVs.update(self.DVGeo.DV_listLocal)
+                all_DVs.update(self.DVGeo.DV_listSectionLocal)
+                all_DVs.update(self.DVGeo.DV_listSpanwiseLocal)
+
+                for dv in all_DVs.keys():
+                    if dv in self.wrt:
+                        temp_dict[dv] = self.jac[dv][i, :].flatten()
+                    else:
+                        temp_dict[dv] = np.zeros(all_DVs[dv].nVal)
+                newJac[i, :] = self.DVGeo.convertDictToSensitivity(temp_dict)
+            # now multiply by the mapping
+            newJac = newJac @ self.DVGeo.DVComposite.u
+            self.jac = {self.DVGeo.DVComposite.name: newJac}
+            self.wrt = [self.DVGeo.DVComposite.name]
+
     def writeTecplot(self, handle):
         """
         Write the visualization of this set of lete constraints

pygeo/constraints/thicknessConstraint.py

@@ -27,7 +27,7 @@ def __init__(self, name, coords, lower, upper, scaled, scale, DVGeo, addToPyOpt,
         # Now get the reference lengths
         self.D0 = np.zeros(self.nCon)
         for i in range(self.nCon):
-            self.D0[i] = np.linalg.norm(self.coords[2 * i] - self.coords[2 * i + 1])
+            self.D0[i] = geo_utils.norm.euclideanNorm(self.coords[2 * i] - self.coords[2 * i + 1])
 
     def evalFunctions(self, funcs, config):
         """
@@ -42,7 +42,7 @@ def evalFunctions(self, funcs, config):
         self.coords = self.DVGeo.update(self.name, config=config)
         D = np.zeros(self.nCon)
         for i in range(self.nCon):
-            D[i] = np.linalg.norm(self.coords[2 * i] - self.coords[2 * i + 1])
+            D[i] = geo_utils.norm.euclideanNorm(self.coords[2 * i] - self.coords[2 * i + 1])
             if self.scaled:
                 D[i] /= self.D0[i]
         funcs[self.name] = D

pygeo/geo_utils/misc.py

@@ -65,7 +65,9 @@ def convertTo1D(value, dim1):
         if temp.shape[0] == dim1:
             return value
         else:
-            raise ValueError("The size of the 1D array was the incorrect shape")
+            raise ValueError(
+                "The size of the 1D array was the incorrect shape! " + f"Expected {dim1} but got {temp.size}"
+            )
 
 
 def convertTo2D(value, dim1, dim2):

pygeo/geo_utils/norm.py

@@ -12,11 +12,7 @@ def euclideanNorm(inVec):
     CS derivatives.
     """
     inVec = np.array(inVec)
-    temp = 0.0
-    for i in range(inVec.shape[0]):
-        temp += inVec[i] ** 2
-
-    return np.sqrt(temp)
+    return np.sqrt(inVec.dot(inVec))
 
 
 def cross_b(a, b, crossb):