-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing initial state values in MPhys #321
Open
lamkina
wants to merge
42
commits into
mdolab:main
Choose a base branch
from
lamkina:mphys_init_guess_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
5a36918
Adding info print control when setting the aeroproblem for ADflow and…
lamkina 177c020
Reverting import ordering
lamkina 4fff8c6
Adding surface coordinate fix
lamkina c580310
Turning on printing in the ADflow solver comp
lamkina 8b68ffc
Merge branch 'main' of github.com:mdolab/adflow into mphys_fix
lamkina 1130ab8
Updated the logic to only print when the aeroproblem actually changes
lamkina 6a17ec4
Updated the logic to only print when the aeroproblem actually changes
lamkina aff3806
Merge branch 'main' into mphys_fix
lamkina 35962fb
Merge branch 'main' into mphys_fix_2
A-CGray 146eaa9
Merge branch 'main' into mphys_fix
A-CGray 2c4405a
Merge branch 'main' into mphys_fix_2
A-CGray fed1c61
Merge branch 'main' into mphys_fix_2
A-CGray 63773ca
Merge branch 'main' into mphys_fix
A-CGray 2b74de3
Adding info print control when setting the aeroproblem for ADflow and…
lamkina 22d9783
Reverting import ordering
lamkina 574b184
Adding surface coordinate fix
lamkina bcce60b
Updated the logic to only print when the aeroproblem actually changes
lamkina 767105f
Merge branch 'mphys_fix_2' of github.com:lamkina/adflow into mphys_fix_2
lamkina 3e750a7
Revert "Updated the logic to only print when the aeroproblem actually…
lamkina 432c7b6
Revert "Adding info print control when setting the aeroproblem for AD…
lamkina 736a62c
Merge branch 'main' of github.com:mdolab/adflow into mphys_fix
lamkina b529803
Switched from passing arguments to using options and module variables
lamkina 169e69a
Forgot to run black
lamkina 76eae9b
Added extra flag for printing info in setAeroProblem
lamkina c1ff161
Removed hacky fix for setting initial states in ADflow
lamkina 3f73f1c
Merge branch 'main' of github.com:mdolab/adflow into mphys_fix
lamkina b8f11da
Re-ran fprettify
lamkina 6edb1db
Removed unnecessary print logic
lamkina 7322d05
Merge branch 'mphys_fix_2' of github.com:lamkina/adflow into mphys_in…
lamkina 483865b
Fixed updatebcdataalllevels calls
lamkina cbb68d3
Free stream states are working using _set_vectors()
lamkina d26c838
Need to turn printing back on after setting the AP
lamkina 530ad9e
Merge branch 'mphys_fix' of github.com:lamkina/adflow into mphys_init…
lamkina 267b7b7
Ran black again
lamkina ed0c6fd
Removing typo
lamkina 947282e
Merge branch 'main' into mphys_init_guess_fix
lamkina e0b0d5a
Merge branch 'main' into mphys_init_guess_fix
A-CGray 261172d
Merge branch 'main' of github.com:mdolab/adflow into mphys_init_guess…
lamkina b45bab5
Merge branch 'main' of github.com:mdolab/adflow into mphys_init_guess…
lamkina 4d5ecf6
Merge branch 'main' of github.com:mdolab/adflow into mphys_init_guess…
lamkina d26295d
Cleaning up missed output printing
lamkina 78b8cc0
Merge branch 'main' into mphys_init_guess_fix
A-CGray File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,12 @@ def __init__(self, comm=None, options=None, debug=False, dtype="d"): | |
curDir = os.path.basename(os.path.dirname(os.path.realpath(__file__))) | ||
self.adflow = MExt.MExt("libadflow", curDir, debug=debug)._module | ||
|
||
# This is a flag not exposed to the user as an option that controls | ||
# printing the boundary condition warnings. This should only | ||
# be used in the MPhys layer when we make multiple calls to | ||
# updateBCAllLevels. | ||
self.adflow.inputiteration.printbcwarnings = True | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
libLoadTime = time.time() | ||
|
||
# Information for base class: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that this was retained after merging (same for above). I think you probably want to restore the previous state as done in PR #307. See here for original comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'm not sure how I did this, but nonetheless I'll get it fixed.