Separation constraint using surface vector projection #238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 41.45% 41.50% +0.04%
==========================================
Files 13 13
Lines 4069 4069
==========================================
+ Hits 1687 1689 +2
+ Misses 2382 2380 -2 ☔ View full report in Codecov by Sentry. |
Thanks for the comments @sseraj |
sseraj
changed the title
doc/options.yaml
Outdated
| sepSensorModel: | ||
| desc: > | ||
| This option allows to pick 3 separation sensor models. | ||
| heaviside: Based on (Kenway2017b) |
There was a problem hiding this comment.
Also briefly explain this method like you explained the other 2 options.
doc/options.yaml
Outdated
| @@ -1527,16 +1527,42 @@ verifyExtra: | |||
| This option is for debugging the adjoint only. | |||
| It is used to verify dIda. | |||
|
|
|||
| sepSensorModel: | |||
| desc: > | |||
| This option allows to pick 3 separation sensor models. | |||
There was a problem hiding this comment.
change to "pick one of 3 separation sensor methods".
doc/options.yaml
Outdated
| ``0`` means no separation and ``1`` means that the flow is fully separated. | ||
| Although this method is formulated for 3D cases, it is appropriate for airfoils. However, for 3D cases, please use ``surfvec_ks`` option, which has KS aggregation to aggregate the maximum separation sensor value to be constrained. This option will effectively alleviate separation anywhere on the interested surface and provide separation free design. On the other hand, ``surfvec`` option may not guarantee to achieve separation free design when the separation happens in a very smaller region and thus, the integration over this region may not violate the constraint. | ||
| surfvec_ks: This method uses similar formulation to ``surfvec`` to compute the maximum separation sensor value on a desired surface instead of integrating over this surface. | ||
| Therefore, this maximum separation sensor value from KS aggregation function can be constrained to alleviate separation. |
There was a problem hiding this comment.
change to "... function can be used to constrain separation."
doc/options.yaml
Outdated
| desc: > | ||
| This option allows to pick 3 separation sensor models. | ||
| heaviside: Based on (Kenway2017b) | ||
| surfvec: Surface vector projection. The separation is based on how much the local flow velocity deviates from the desired flow direction. |
There was a problem hiding this comment.
I have several problems with this explanation. First, the sweep angle is not explained. Why would we want to correct for sweep in the first place?
You say this is formulated for 3d, but applies to airfoils. That makes no sense. If it is only applicable to airfoils say so.
How the value varies from 0 to 1 is not well explained. Again, this is also with how the sweep is defined.
What is a common use case? Do you constrain separation to be below 0.0 or 0.5?
doc/options.yaml
Outdated
| See "Buffet-Onset Constraint Formulation for Aerodynamic Shape Optimization" (Kenway2017b) for more details. | ||
|
|
||
| sepSweepAngleCorrection: | ||
| desc: > | ||
| This option is only for ``surfvec`` and ``surfvec_ks`` separation models in ``sepSensorModel``. |
There was a problem hiding this comment.
what is the sweep direction? Do you account for fwd or bwd sweep? Do you account for lift direction being y or z?
This explanation needs to be a lot better. Right now it is not clear at all what it is doing.
|
Thanks for the comments @anilyil |
Purpose
This PR includes the new separation constraint in ADflow. The previous separation constraint and the new one is available. Each options can be selected through adflow option.
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable