Fix plot_wing.py to work for matplotlib v3.8+ #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the use of the dist attribute for 3-D plots, which has been
deprecated in the recent matplotlib versions.
* Make the 3-D view behavior consitent in plot_wingbox.py, i.e., the
view does not reset if the iteration is changed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 104 104
Lines 6470 6470
=======================================
Hits 6079 6079
Misses 391 391 ☔ View full report in Codecov by Sentry. |
kanekosh
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix plot_wing.py to work for matplotlib v3.8+.
The
distattribute for 3-D plots has been deprecated in recent matplotlib versions.See related Issue #423
Also made the 3-D view behavior consistent in plot_wingbox.py (the 3-D view should not reset if the iteration is changed).
Expected time until merged
1 day
Code review should only take a few minutes.
Type of change
Bugfix (non-breaking change which fixes an issue)
Testing
Ran the run_CRM.py and run_aerostruct_uCRM_multipoint.py examples, and also confirmed that the views don't reset it the iteration is changed.
Tested with matplotlib versions:
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable