Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SLSQP to airfoil and wing tests #98

Merged
merged 8 commits into from Feb 9, 2024
Merged

Add SLSQP to airfoil and wing tests #98

merged 8 commits into from Feb 9, 2024

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Jun 8, 2023 •
edited

Purpose

Per title.

Closes #96, #97

Expected time until merged

Once tests pass.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner June 8, 2023 12:54
@eirikurj eirikurj requested review from yqliaohk and anilyil June 8, 2023 12:54
@eirikurj
Copy link
Contributor Author

eirikurj commented Jun 8, 2023

Tests are failing/timing out due to issue described in #96

@eirikurj eirikurj mentioned this pull request Jan 31, 2024
Merged
13 tasks
ewu63
ewu63 previously approved these changes Feb 4, 2024
View reviewed changes
@sseraj sseraj linked an issue Feb 5, 2024 that may be closed by this pull request
SLSQP is not included as an optimizer in tests #97
Closed
sseraj
sseraj reviewed Feb 5, 2024
View reviewed changes
tests/test_analysis.py Outdated
shutil.copy("../../aero/analysis/wing_vol_coarsen.cgns", "wing_vol_coarsen.cgns")
shutil.rmtree("output", ignore_errors=True)
cmd = ["python", "aero_opt.py"]
subprocess.check_call(mpiCmd + cmd + gridFlag + SLSQP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of duplicated lines in these tests. Would it make sense to create a parameterized class?

@sseraj sseraj merged commit 75d8ee8 into main Feb 9, 2024
9 checks passed
@sseraj sseraj deleted the addSLSQPToTests branch February 9, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewu63 ewu63 ewu63 approved these changes

@sseraj sseraj sseraj approved these changes

@yqliaohk yqliaohk Awaiting requested review from yqliaohk yqliaohk is a code owner automatically assigned from mdolab/mach_aero_maintainers

@anilyil anilyil Awaiting requested review from anilyil anilyil is a code owner automatically assigned from mdolab/mach_aero_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLSQP is not included as an optimizer in tests Bug when running MACH-Aero tutorial with SLSQP
4 participants
@eirikurj @ewu63 @sseraj @A-CGray