Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker VS Code instructions #149

Merged
merged 2 commits into from Apr 29, 2024
Merged

Docker VS Code instructions #149

merged 2 commits into from Apr 29, 2024

Conversation

gawng
Copy link
Contributor

@gawng gawng commented Apr 9, 2024 •
edited

Purpose

migrate docker instructions out of private docs https://github.com/mdolab/private-docs/pull/318

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gawng gawng requested a review from a team as a code owner April 9, 2024 16:02
@gawng gawng requested review from yqliaohk and sseraj April 9, 2024 16:02
@gawng gawng requested a review from hajdik April 29, 2024 16:06
hajdik
hajdik approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@hajdik hajdik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hajdik hajdik merged commit ded363b into main Apr 29, 2024
8 checks passed
@hajdik hajdik deleted the docker-vscode branch April 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajdik hajdik hajdik approved these changes

@eirikurj eirikurj eirikurj approved these changes

@yqliaohk yqliaohk Awaiting requested review from yqliaohk yqliaohk is a code owner automatically assigned from mdolab/mach_aero_maintainers

@sseraj sseraj Awaiting requested review from sseraj sseraj is a code owner automatically assigned from mdolab/mach_aero_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gawng @hajdik @eirikurj