fix(ad-free): show minimal muted top-banner fallback #10942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, the page jumps, because the SSR html contains the top-banner and we only hide it when we know that the user has the ad-free experience enabled. |
This is a compromise. Hiding the top-banner entirely isn't currently feasible, because it causes a layout shift upon load.
caugner
force-pushed
the
MP-1059-hide-top-banner-if-ad-free
branch
from
163bed3
to
9aa165e
Compare
caugner
changed the title
|
Closing for now, we will re-consider this after the ongoing rewrite work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We’re showing the
top-banner fallback, even if paying subscribers have enabled the Ad-Free Experience.
Solution
Show a minimal top-banner fallback copy instead if the Ad-Free Experience is enabled.
Note: We cannot currently hide the top-banner entirely, because this would cause a layout shift.
Screenshots
Before
After
How did you test this change?
Ran
yarn && yarn devlocally with running rumba, logging in as a paying subscriber and enabling the Ad-Free Experience in the user settings.