Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Upgrade node.js in Vagrant VM #2354

Merged
merged 2 commits into from
May 2, 2014
Merged

Conversation

lmorchard
Copy link
Contributor

This should hopefully get us up to roughly the same version of node.js as stage & prod.

To check this, try running a vagrant provision on an existing VM.

Then, run the kumascript test suite:

cd ~/src/kumascript
./node_modules/.bin/nodeunit tests

All tests should pass, and then you should be able to spot check a few pages with kumascript macros.

For extra credit, do a vagrant destroy && vagrant up and try the kumascript test suite & spot check again to ensure everything works on a fresh VM.

@groovecoder
Copy link
Contributor

Hmm ... not sure this is related, but I'm getting kumascript 204 errors.
ks_error

11:44:48 kumascript.1 | info: 127.0.0.1 - - [Fri, 02 May 2014 11:44:48 GMT] "GET /docs/en-US/Tools/Web_Console HTTP/1.1" 204 - "-" "python-requests/1.1.0 CPython/2.6.9 Linux/3.2.0-23-generic-pae" 88 source=server, pid=9491

Even after a vagrant destroy && vagrant up. Seems like I've hit this before though and it's some kind of extra config or something that I always over-look ... ? I checked thru our vagrant install docs again but don't see anything there.

Still poking; not sure if I should block the merge on this or not.

…ipt to better report connection-level errors when fetching source doc
@lmorchard
Copy link
Contributor Author

Managed to reproduce this, turns out it's an issue with the self-signed SSL cert in the VM. I'd set an env var in my shell and then forgot to add it to the vagrant BASH profile.

Updated the PR to include that, but also there's a new kumascript PR that needs merging first. That tweaks kumascript to better report this kind of error, rather than just 204 No Content

@groovecoder
Copy link
Contributor

Merged mdn/kumascript#37 but Travis is still unable to check it out. :/

@groovecoder
Copy link
Contributor

Nevermind, Travis is slow and was showing the previous build output in the console log.

groovecoder added a commit that referenced this pull request May 2, 2014
@groovecoder groovecoder merged commit 7ff91b2 into mdn:master May 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants