Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a broken link flaw #33548

Merged
merged 1 commit into from May 13, 2024
Merged

fix a broken link flaw #33548

merged 1 commit into from May 13, 2024

Conversation

OnkarRuikar
Copy link
Contributor

We should avoid preemptively creating links to future docs.

@OnkarRuikar OnkarRuikar requested review from a team as code owners May 11, 2024 04:45
@OnkarRuikar OnkarRuikar requested review from Elchi3 and removed request for a team May 11, 2024 04:46
@github-actions github-actions bot added Content:WebAPI Web API docs Content:HTTP HTTP docs size/xs 0-5 LoC changed labels May 11, 2024
Copy link
Contributor

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, issues are a good place to track the not-yet written pages as TODOs. Thanks, Onkar! 🎉

@bsmth bsmth merged commit 2d9c4b8 into mdn:main May 13, 2024
7 checks passed
@OnkarRuikar OnkarRuikar deleted the fix_flaw branch May 13, 2024 12:12
@OnkarRuikar
Copy link
Contributor Author

issues are a good place to track the not-yet written pages as TODOs.

This is a bad use of flaws mechanism. 😞 Once we get the flaw count to zero then we can ask reviewers to not merge PRs till all the flaws are fixed. After sidebar flaw related PRs are merged there will be only 500+ flaws remaining and almost all of them will be broken link flaws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:WebAPI Web API docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants