Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec URLs for RTP header extension controls #23060

Merged
merged 2 commits into from
May 13, 2024
Merged

Add spec URLs for RTP header extension controls #23060

merged 2 commits into from
May 13, 2024

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented May 10, 2024 •
edited

This PR adds the spec URLs for the features added in #22872.

@queengooborg
Add missing features for RTCRtpTransceiver API
5189a81 
This PR adds the missing features of the `RTCRtpTransceiver` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.10.6).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/RTCRtpTransceiver
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 10, 2024
@queengooborg queengooborg mentioned this pull request May 11, 2024
Merged
@queengooborg queengooborg changed the title Add missing features for RTCRtpTransceiver API Add spec URLs for RTP header extension controls May 11, 2024
teoli2003
teoli2003 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit f4973c7 into mdn:main May 13, 2024
6 checks passed
@queengooborg queengooborg deleted the api/RTCRtpTransceiver/additions branch May 13, 2024 14:54
@foolip
Copy link
Collaborator

foolip commented May 19, 2024

@queengooborg I came across this in git log while looking for a recent collector-backed change to do some testing with. The commit itself looks it was made by the collector, but it looks like a manual change. For manual changes, is it possible to update your scripts so that commit message and PR descriptions align? This could avoid future headscratching from trying to figure out why the collector made a certain change when actually it was a manual edit. (In this case it's easy to tell, but not in cases where versions are updated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@queengooborg @foolip @teoli2003