Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add running to typescript definition #71

Merged
merged 6 commits into from Jun 25, 2023
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jun 25, 2023

No description provided.

@Uzlopak Uzlopak changed the title running-types add running to typescript definition Jun 25, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 25, 2023

When running the jsdoc typechecking with typescript in vscode on avvio, it is reporting that running is not defined.

image

@mcollina
Copy link
Owner

Can you add it to example.ts?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 25, 2023

I originally wanted to add it, but example.ts seemed to be some working code example, so I hesitated.

Will add.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 25, 2023

done.

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 25, 2023

@mcollina
ptal

@mcollina mcollina merged commit be3943a into mcollina:master Jun 25, 2023
15 checks passed
@Uzlopak Uzlopak deleted the patch-1 branch June 25, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants