add esm support #48
Open
add esm support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
May 28, 2021
|
|
||
| # generated files | ||
| queue.mjs |
There was a problem hiding this comment.
If you're adding to .gitignore I wouldn't expect the file to be checked in.
Also, what about the .map file?
There was a problem hiding this comment.
oh whoops. I think I created it and then I wanted to find out how @mcollina deploys this / how he expects people to use it - i.e. direct from github on occasion, etc, to determine if it is built and checked in, or built at deploy time.
The ci config only runs tests, there doesn't seem to be any automated deployment.
|
@mcollina would you prefer we build the esm version at package build time, or do you prefer it built and checked in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44