Emit drain event after pause/resume combo

Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina · Feb 5, 2024 · 1684b5c · 1684b5c
1 parent 22d8dc1
commit 1684b5c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/queue.js b/queue.js
@@ -93,6 +93,11 @@ function fastqueue (context, worker, _concurrency) {
   function resume () {
     if (!self.paused) return
     self.paused = false
+    if (queueHead === null) {
+      _running++
+      release()
+      return
+    }
     for (; queueHead && _running < _concurrency;) {
       _running++
       release()

diff --git a/test/test.js b/test/test.js
@@ -624,3 +624,19 @@ test('unshift with worker throwing error', function (t) {
     t.match(err.message, /test error/, 'error message should be "test error"')
   })
 })
+
+test('pause/resume should trigger drain event', function (t) {
+  t.plan(1)
+
+  var queue = buildQueue(worker, 1)
+  queue.pause()
+  queue.drain = function () {
+    t.pass('drain should be called')
+  }
+
+  function worker (arg, cb) {
+    cb(null, true)
+  }
+
+  queue.resume()
+})