Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace subarg with @minimistjs/subarg #524

Merged
merged 1 commit into from May 3, 2024

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented May 2, 2024

Relates to #520.

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljharb
Copy link
Contributor Author

ljharb commented May 2, 2024

Looks like one of the failures might be pre-existing, and the other one is because setup-node is failing to download node 14.

You may be interested in using ljharb/actions/node/install for the Mac OS and Linux tests, which uses nvm and thus can forever install every version of node > 0.6.

@GlenTiki
Copy link
Collaborator

GlenTiki commented May 3, 2024

Broken tests need triage outside of this - I'll merge this and review tests later this week. Thanks for the module suggestion @ljharb :)

@GlenTiki GlenTiki merged commit b929456 into mcollina:master May 3, 2024
12 of 14 checks passed
@ljharb ljharb deleted the subarg branch May 3, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants