Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting of common properties (-mmt=n option is ignored by many handlers) #349

Merged
merged 1 commit into from Sep 6, 2023
Merged

Fix setting of common properties (-mmt=n option is ignored by many handlers) #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions CPP/7zip/Archive/Common/HandlerOut.cpp
View file
Open in desktop
Expand Up @@ -203,8 +203,9 @@ HRESULT CMultiMethodProps::SetProperty(const wchar_t *nameSpec, const PROPVARIAN

{
HRESULT hres;
if (SetCommonProperty(name, value, hres))
return hres;
SetCommonProperty(name, value, hres);
/* don't return here, since many handlers set common properties (e. g. kNumThreads)
with SetCoderProperties, so add it also as prop by its ID from name below */
}

UInt32 number;
Expand Down Expand Up @@ -258,11 +259,9 @@ HRESULT CSingleMethodProps::SetProperty(const wchar_t *name2, const PROPVARIANT
}
{
HRESULT hres;
if (SetCommonProperty(name, value, hres))
{
// processed = true;
return S_OK;
}
SetCommonProperty(name, value, hres);
/* don't return here, since many handlers set common properties (e. g. kNumThreads)
with SetCoderProperties, so add it also as prop by its ID from name below */
}
RINOK(ParseMethodFromPROPVARIANT(name, value));
return S_OK;
Expand Down