Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ZS" to the file manager's name to allow for differentiation #326

Closed
wants to merge 4 commits into from
Closed

Conversation

Jevil7452
Copy link
Contributor

@Jevil7452 Jevil7452 commented May 27, 2023

At this moment, if you have both 7-Zip (normal) and 7-Zip ZSTD installed, it can be confusing to know which one is which
image
With this PR, the names are different, so it's easier to know which one is which
image
This PR also changes the names used in the Start menu
image
(To whoever decides to accept this PR, please ignore the "Update build-win.yml" commits, that was me trying to get Github Actions to work)

@mcmilk
Copy link
Owner

mcmilk commented May 28, 2023

Thank you, I have added this pr.
Why should workflow_dispatch also be triggered?

@mcmilk mcmilk closed this May 28, 2023
@Jevil7452
Copy link
Contributor Author

The reason why I added workflow_dispatch to the Github Actions files was because I was trying to run Github Actions manually, to test out my code changes, as I couldn't get the code to compile on my PC, but I didn't see a run workflow button, so I looked up online how to get it, and the results i found said to add workflow_dispatch, so I did, however it would've been better to just enable Github Actions before pushing my commit related to changing the file manager's name. I apologize for these unneeded commits.

@mcmilk
Copy link
Owner

mcmilk commented May 28, 2023

No need for apologizing - everything is fine ;-)
Thanks for you pull request and the next release will have this applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants