New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes string quotation in cmd-line from UI #313
Conversation
This reverts commit d942849 (excepting bump version).
…of backslash and quotes); fixes mcmilkgh-312 for new command-line parser algorithm (mcmilkgh-307, mcmilkgh-310)
Although it'd probably expect another amend - a different version of |
Tested this build and error is sadly still the same. |
Thx for feedback! |
It's about the shell context menu and only immediate extracting options do not work. I made a screencast maybe that helps for better understanding: |
The question is whether you reinstalled or reregistered the shell integration with newest build version too? Because otherwise, previous version, is incompatible to new 7z executables. |
I just ran the setup and rebooted for safety’s sake. I can’t tell if the installer reinstalls or re-registers the shell integration. However, handling is done by 7zip.dll which should be corresponding. Anyways, I removed the context menu and added it again through Options but the problem remains. |
Hmm... I can't reproduce the error. @akuropka Are you really sure it is the newest version of What do you see in the registry and file system for the
DLL from latest releases would have different timestamp (modified 05.04.2023) and SHA256 hash. |
Actually I was never sure if |
Merged by hand - thanks a lot @sebres |
This should fix #312 for new command-line parser algorithm (#307, #310).
Proposed PR:
(it reverts commit d942849, excepting version bump);
GetQuotedString
, moved to MyString now);GetQuotedString
which uses correct windows command-line notation now (escaping of backslashes and quotes);I did not test it from explorer integration (didn't install/register it yet), so would be nice if someone could test it...
Only tested from compiled
7zFM.exe
, for instance from its context menu where previously (without that fix) it failed with same error like in #312.Test and review are welcome.