Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]fix vizro ai chart example #472

Merged
merged 9 commits into from May 14, 2024
Merged

Conversation

Anna-Xiong
Copy link
Contributor

@Anna-Xiong Anna-Xiong commented May 10, 2024

Description

when running the example dashboard code in the "Vizro-AI chart within vizro dashboard" section here,

  • it gives an error complaining about CapturedCallable
  • caused by the px.box chart being imported from import plotly.express as px instead of import vizro.plotly.express as px

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@Anna-Xiong Anna-Xiong changed the title Docs/fix vizro ai chart example [Docs]fix vizro ai chart example May 10, 2024
@Anna-Xiong Anna-Xiong added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Component: Docs 🗒️ Issue/PR for markdown and API documentation Component: Vizro-AI 🤖 Issue/PR addresses Vizro-AI package labels May 10, 2024
@Anna-Xiong Anna-Xiong marked this pull request as ready for review May 10, 2024 18:09
@lingyielia lingyielia self-requested a review May 11, 2024 02:27
@lingyielia
Copy link
Contributor

Looks like we have several more places using import plotly.express. Shall we replace them all?

@Anna-Xiong
Copy link
Contributor Author

Looks like we have several more places using import plotly.express. Shall we replace them all?

I found only this one more in ai docs, would you mind adding if you detect more here? thank you!

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Anna-Xiong Anna-Xiong merged commit 64d8602 into main May 14, 2024
39 checks passed
@Anna-Xiong Anna-Xiong deleted the docs/fix_vizro_ai_chart_example branch May 14, 2024 16:13
nadijagraca pushed a commit that referenced this pull request May 15, 2024
Co-authored-by: Lingyi Zhang <lingyi_zhang@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Docs 🗒️ Issue/PR for markdown and API documentation Component: Vizro-AI 🤖 Issue/PR addresses Vizro-AI package Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants