Support pull request chaining for GitHub #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate ProjectBranches with BranchInfos for project pull requests in addition to scanned branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to analyze a GitHub PR that targets another PR's branch, analysis fails with an error like
That happens as SonarQube server only stores PR analysis results in the "Pull Requests" area and does not expose it via "Branches", so none are fetched via
/api/project_branches/listendpoint.This change makes a request to the
/api/project_pull_requests/listendpoint and merges its response with the response from/api/project_branches/list.Technical details
PROJECT_PULL_REQUESTS_URLin the same wayPROJECT_BRANCHES_URLis built.CommunityProjectBranchesLoader's test to support mocking of multiple endpoints. 2c15a21 includes just that change without any production code changes, edacbe2 that makes the actual change then only needs minimal changes in the unit test.