FEAT: Allow 0 desiredCount for deploy-ecs action #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
changed the title
|
@rymarczy were you able to try this with LAMP? |
|
@paulswartz This ran successfully on LAMP staging with 2 running tasks and 1 non-running task: |
paulswartz
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LAMP team does not always have all of our ECS instances running at the time of a deploy, meaning the ECS deployment details
desiredCountcan be set to 0.This change allows a
desiredCountvalue of 0 through the use of a boolean input flagallow-zero-desiredinput on the deploy-ecs action. By default this flag is set tofalsewhich should have zero impact on existing users of this action.