-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response_type to params #3
base: master
Are you sure you want to change the base?
Conversation
src/GoogleAuthorize.js
Outdated
include_granted_scopes: true, | ||
discoveryDocs, | ||
prompt, | ||
scope, | ||
}; | ||
|
||
if (responseType === 'code') { | ||
if (params.response_type === 'code') { | ||
params.access_type = 'offline'; | ||
params.response_type = 'code'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this duplicate re-assign. please remove line 76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxwellGBrown any chance to do this, and to also add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliranamar Thank you; Dropped line 76.
@advance512 Will look into it. Doesn't look as if there's any tests for the click event, and gapi
isn't mocked out or anything, so I'll see if the effort required matches my desired involvement 😬 .
What is the status of this? Any chance we can get this merged + published? |
There's handling for
responseType="code"
but it's hard-coded.Google allows
responseType="id_token token"
which is in the README table, but it is not actually passed toparams
.